criu: Version 4.2 (CRIUTIBILITY) #2814
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianreber
approved these changes
Nov 8, 2025
Member
|
@avagin Thank you for creating the release. We currently don't have a way of disabling the parallel restore for the amdgpu plugin, and this functionality appears to break restoring of PyTorch workloads (#2812). Would it be possible to add an option that allows users to disable this functionality or do you have any suggestions on how to handle this? |
This patch fixes the following error:
$ sudo make -C test/others/criu-coredump run
...
Traceback (most recent call last):
File "/home/circleci/criu/coredump/coredump", line 55, in <module>
main()
File "/home/circleci/criu/coredump/coredump", line 47, in main
coredump(opts)
File "/home/circleci/criu/coredump/coredump", line 14, in coredump
cores = generator(os.path.realpath(opts['in']))
File "/home/circleci/criu/coredump/criu_coredump/coredump.py", line 192, in __call__
self.coredumps[pid] = self._gen_coredump(pid)
File "/home/circleci/criu/coredump/criu_coredump/coredump.py", line 214, in _gen_coredump
cd.vmas = self._gen_vmas(pid)
File "/home/circleci/criu/coredump/criu_coredump/coredump.py", line 992, in _gen_vmas
v.data = self._gen_mem_chunk(pid, vma, v.filesz)
File "/home/circleci/criu/coredump/criu_coredump/coredump.py", line 879, in _gen_mem_chunk
page_mem = self._get_page(pid, page_no)
File "/home/circleci/criu/coredump/criu_coredump/coredump.py", line 797, in _get_page
num_pages = m.get("nr_pages", m.compat_nr_pages)
AttributeError: 'dict' object has no attribute 'compat_nr_pages'
+ exit 1
make[1]: *** [Makefile:3: run] Error 1
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Signed-off-by: Andrei Vagin <avagin@google.com>
This functionality (checkpoint-restore#2527) is being reverted and excluded from this release due to issue checkpoint-restore#2812. It will be included in a subsequent release once all associated issues are resolved. Signed-off-by: Andrei Vagin <avagin@google.com>
avagin
force-pushed
the
v4.2-release
branch
2 times, most recently
from
a106f07 to
3e716ff
Compare
When we compare two list of vma-s, we need to take into account that some of them could be merged. Fixes #12286 Signed-off-by: Andrei Vagin <avagin@google.com>
Major changes: * plugins/amdgpu: Implement parallel restore * Handle processes with uprobes vma * Fix: getsockopt usage for SO_PASSCRED/SO_PASSSEC on Linux 6.16 * Relax ELF magic check to support MIPS libraries * pagemap: prevent integer overflow in pagemap_len This release's name is a nod to the growing challenge we face in maintaining compatibility across the rapidly evolving Linux kernel ecosystem. The full changelog can be found here: https://criu.org/Download/criu/4.2. Signed-off-by: Andrei Vagin <avagin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
This release's name is a nod to the growing challenge we face in maintaining compatibility across the rapidly evolving Linux kernel ecosystem.